-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Test all notebooks vs stable cirq after the release #7255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
pavoljuhas
merged 6 commits into
quantumlib:main
from
pavoljuhas:after-release-stabilize-notebooks
Apr 10, 2025
Merged
Test all notebooks vs stable cirq after the release #7255
pavoljuhas
merged 6 commits into
quantumlib:main
from
pavoljuhas:after-release-stabilize-notebooks
Apr 10, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test all notebooks that pass with cirq head also in isolation with stable cirq.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7255 +/- ##
==========================================
- Coverage 98.66% 98.66% -0.01%
==========================================
Files 1106 1106
Lines 96050 96052 +2
==========================================
- Hits 94769 94765 -4
- Misses 1281 1287 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mhucka
approved these changes
Apr 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
3b1f520
to
2c76aeb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/notebook-testing
priority/after-1.5
Leave for after the Cirq 1.5 release
priority/p1
Fix is needed as soon as possible. Should be staffed. It is blocking some major flows for users
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make all notebook tests use stable cirq and synchronize
SKIP_NOTEBOOKS
in
notebook_test.py
andisolated_notebook_test.py
so the same setsof notebooks test vs cirq head and vs last cirq release.
Ref: https://github.com/quantumlib/Cirq/blob/main/docs/dev/notebooks.md#lifecycle