Skip to content

Test all notebooks vs stable cirq after the release #7255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

pavoljuhas
Copy link
Collaborator

@pavoljuhas pavoljuhas commented Apr 9, 2025

Make all notebook tests use stable cirq and synchronize SKIP_NOTEBOOKS
in notebook_test.py and isolated_notebook_test.py so the same sets
of notebooks test vs cirq head and vs last cirq release.

Ref: https://github.com/quantumlib/Cirq/blob/main/docs/dev/notebooks.md#lifecycle

@pavoljuhas pavoljuhas added the priority/after-1.5 Leave for after the Cirq 1.5 release label Apr 9, 2025
Copy link

codecov bot commented Apr 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.66%. Comparing base (c1e2fe4) to head (2c76aeb).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7255      +/-   ##
==========================================
- Coverage   98.66%   98.66%   -0.01%     
==========================================
  Files        1106     1106              
  Lines       96050    96052       +2     
==========================================
- Hits        94769    94765       -4     
- Misses       1281     1287       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pavoljuhas pavoljuhas added the priority/p1 Fix is needed as soon as possible. Should be staffed. It is blocking some major flows for users label Apr 9, 2025
@pavoljuhas pavoljuhas marked this pull request as ready for review April 10, 2025 18:57
Copy link
Contributor

@mhucka mhucka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavoljuhas pavoljuhas force-pushed the after-release-stabilize-notebooks branch from 3b1f520 to 2c76aeb Compare April 10, 2025 19:39
@pavoljuhas pavoljuhas enabled auto-merge April 10, 2025 19:42
@pavoljuhas pavoljuhas added this pull request to the merge queue Apr 10, 2025
Merged via the queue into quantumlib:main with commit 92f71b6 Apr 10, 2025
38 checks passed
@pavoljuhas pavoljuhas deleted the after-release-stabilize-notebooks branch April 10, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/notebook-testing priority/after-1.5 Leave for after the Cirq 1.5 release priority/p1 Fix is needed as soon as possible. Should be staffed. It is blocking some major flows for users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants