Skip to content

typst-css - correctly handle unsupported font-weight values #12752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2025

Conversation

cderv
Copy link
Collaborator

@cderv cderv commented May 16, 2025

Note

This PR solves the problem with 1.8.5 that prevent quarto-web to built

This is follow up from

Unsupported font-weight are translated to nil with a warning, but quote() does not handle nil

for example in the great_tables example font-weight: initial

This PR handles the error by handling nil and do nothing

@cderv cderv requested a review from gordonwoodhull May 16, 2025 13:16
@posit-snyk-bot
Copy link
Collaborator

posit-snyk-bot commented May 16, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@gordonwoodhull
Copy link
Contributor

Thanks @cderv! LGTM

@cderv cderv merged commit f7b65ec into main May 16, 2025
49 checks passed
@cderv cderv deleted the fix/typst-css-font-weight branch May 16, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants