Skip to content

Broken make fmt - license check has been deprecated from Rust nightly #1673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fulmicoton opened this issue Jun 27, 2022 · 5 comments · Fixed by #1681
Closed

Broken make fmt - license check has been deprecated from Rust nightly #1673

fulmicoton opened this issue Jun 27, 2022 · 5 comments · Fixed by #1681
Assignees
Labels
bug Something isn't working

Comments

@fulmicoton
Copy link
Collaborator

See rust-lang/rustfmt#5103

We need to find an alternative to do license check.

@fulmicoton fulmicoton added the bug Something isn't working label Jun 27, 2022
@fmassot fmassot self-assigned this Jun 27, 2022
@fmassot
Copy link
Collaborator

fmassot commented Jun 27, 2022

I did not find an alternative in rust.
We can either:

I'm in favor of option 2.

@guilload
Copy link
Member

There used to be license-check and license-fix commands in the Makefile based on this tool, which was clunky in my opinion but somewhat got the job done. We can reinstate those commands.

@fmassot
Copy link
Collaborator

fmassot commented Jun 27, 2022

yes, good idea

@saroh
Copy link
Collaborator

saroh commented Jun 27, 2022

You could use diff for licence-check, then patch + cleanup diffs in license-fix.

$ diff <(sed 's/{\\d+}/2022/' .license_header.txt) <(head -n 19 quickwit-search/src/lib.rs)
1c1
< // Copyright (C) 2022 Quickwit, Inc.
---
> // Copyright (C) 2021 Quickwit, Inc.

@fulmicoton
Copy link
Collaborator Author

The previous tool sucked. I tried to package @saroh's diff solution into a bash script. It seems decent enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants