Skip to content

Add Labels for Files and Folders #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

kaka-ruto
Copy link

First of all, thanks for the awesome tutorial! It's a masterpiece and can't say thank you enough for this Go into with TDD.

This PR makes it clearer for beginners the folders and files to put their code and tests. When I was starting, I had to look on Github the file names and their folders. Seniors could easily figure that out, but for beginners that may be a challenge and I hope to save them time thinking/checking Github.

I aim to do the same for more files (I am adding them as I study :))

@kaka-ruto kaka-ruto force-pushed the add-label-for-files-and-folders branch from d0d650e to c6c25ae Compare July 18, 2019 10:34
@kaka-ruto kaka-ruto force-pushed the add-label-for-files-and-folders branch from c6c25ae to bf84c7c Compare July 18, 2019 10:38
@quii
Copy link
Owner

quii commented Jul 25, 2019

Hey

Thanks for the kind words and sorry for the slow reply.

I dont think it's too important precisely what folder you work in. The idea is you start each chapter in a new folder and you can call it whatever you like; I dont really want to be very prescriptive.

That said, if you found it a bit confusing you're probably not the only one.

Rather than prescribing each specific folder, what do you think about adding some kind of generic instruction. "Make a new folder for each new chapter you work on"

@sanjib
Copy link
Contributor

sanjib commented Jul 25, 2019

The idea is you start each chapter in a new folder and you can call it whatever you like; I dont really want to be very prescriptive.

It's really nice to leave the folder naming choice to the end user. For example, when learning, I like to prefix my folders with a number so I can refer back to them more easily in the future. Works well for me but someone might prefer something else.

Here is an example, in a single project/repo, I have all the folders numbered sequentially corresponding to each topic/chapter:

image

@kaka-ruto
Copy link
Author

@quii and @sanjib, I definitely agree with both of you - we should leave to the user the decision to create and name the folder/file whatever they like.

Earlier on, being a pretty new Gopher, I found it confusing that we didn't mention the what folder to have our files on. So to help out, it would be of great help to leave a generic instruction for users to make a new and descriptive folder for them to have their files on.

@quii quii closed this Aug 22, 2019
@quii
Copy link
Owner

quii commented Aug 22, 2019

Just committed a short note as discussed

quii added a commit that referenced this pull request Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants