Port to matrix-rust-sdk-crypto #820
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiasFella
force-pushed
the
tobias/rust-sdk-crypto
branch
3 times, most recently
from
2bf6831 to
f01f524
Compare
TobiasFella
force-pushed
the
tobias/rust-sdk-crypto
branch
3 times, most recently
from
0796120 to
c76e066
Compare
TobiasFella
force-pushed
the
tobias/rust-sdk-crypto
branch
4 times, most recently
from
a07274a to
8c33951
Compare
TobiasFella
force-pushed
the
tobias/rust-sdk-crypto
branch
2 times, most recently
from
453f6cc to
8e4ad29
Compare
TobiasFella
force-pushed
the
tobias/rust-sdk-crypto
branch
14 times, most recently
from
214ccab to
d3814ed
Compare
TobiasFella
force-pushed
the
tobias/rust-sdk-crypto
branch
2 times, most recently
from
0c7f343 to
b300831
Compare
TobiasFella
force-pushed
the
tobias/rust-sdk-crypto
branch
2 times, most recently
from
0f8fc8b to
fea61b9
Compare
Co-authored-by: Alexey Rusakov <[email protected]>
Also, use GitHub Actions to pre-calculate Sonar's build wrapper invocation string.
Looks like QHash with its original iterators is not-quite a std::range.
Because RoomStateView inherits privately from QHash, GCC cannot get to QHash::begin() from outside the class when checking it against range concepts. Not sure it's actually the correct behaviour - but my C++-fu is not sufficient to figure out. Merely using events() that returns a reference to the underlying QHash should suffice.
It's not a system header.
Along with this, introduce fromRustJson() that wraps around the frequent `fromJson<>(jsonFromRust(...))` stack of calls.
(cherry picked from commit 47a8f5e)
Merged
Restoring prior API where applicable.
That was the way before, and there's nothing preventing us from keeping it like this. The Rust part still accepts it Base64-encoded.
The former onSyncSuccess() function is not really handling sync success, so its new name is processSyncData(); and onSyncSuccess() is now literally the handler of SyncJob::success() signal.
Both were needed to interface with Olm; CStructPtr just has no place with matrix-rust-crypto-sdk, and viewAsByteArray() is superceded by bytesFromRust() because we can't borrow the buffer allocated in Rust and it's unsafe to use it without borrowing (rust::String is not meant to last for long).
Requires newer cxx-bridge that models rust::Slice as std::ranges::contiguous_range.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
migration from current database to rust-sdk database (?)