Fix OLM workflow #1715
Merged
Fix OLM workflow #1715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We stopped depending on a container image that was hosted in GCP. This image is gone, and the workflow is now composed with small steps that do something concrete. The tools required are either already available in GitHub runners, or installed as part of a setup step. This ensures that our tooling remains up to date. The "publish" part now is separated in two different jobs, because their steps are not dependant and they can be parallelised. [skip ci]
This commit changes the strategy to determine the OLM bundle version. Previously, it was calculated in every job that needed this information. Now, the bundle version is calculated in the first job that creates the bundle, and passed on via outputs to subsequent dependant jobs. The system tests were racy. Sometimes, they started too soon, before the Cluster Operator was installed. Now, the system tests wait on the status of Subscription. This ensures that Cluster Operator is, at least, installed when the system tests execute. [skip ci]
The "publish" job now uses a Personal Access Token from our robot account. This allows to run authenticated git commands from the job. [skip ci]
The current logic is brittle, and it is guaranteed to break after we release 2.10.0. The problem with `ls -1v` is that it lists in alphabetical order, not in semver order. That means that a list with 2.1.0, 2.9.0, 2.10.0 and 2.11.0 would be listed as: 2.1.0 2.10.0 2.11.0 2.9.0 The previous logic would always yield 2.9.0 (bottom) as the replace version. That is not correct for 2.11.0. The opm validator does not complain by not providing a "replaces" version, so it may just be fine and OLM may have some magic sauce to figure out what version to upgrade to. [skip ci]
Zerpet
force-pushed
the
test-ci/fix-olm-ci
branch
from
ddf9cbf to
d954fa4
Compare
|
FYI @ansd |
MirahImage
approved these changes
Aug 29, 2024
DanielePalaia
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary Of Changes
Fix OLM workflow. It was depending on a container image in GCP. This image is not available anymore. This PR
removes that dependency.