Update registry references to new name #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We renamed our DockerHub registry and have to reflect the same in the manifests. It also simplifies the manifest structure by removing some patches that were always applied. If a patch is always applied, it should be part of the resource itself. Images are not set using kustomize 'image' field, instead of using a patch. Overlays still need to use a patch because they change the image pull policy.
coro
approved these changes
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to #338
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Summary Of Changes
We renamed our DockerHub registry and have to reflect the same in the manifests.
It also simplifies the manifest structure by removing some patches that were always applied. If a patch is always applied, it should be part of the resource itself.
Images are not set using kustomize 'image' field, instead of using a patch. Overlays still need to use a patch because they change the image pull policy.
Additional Context
This PR requires a change into the pipeline to avoid failures in the
operator-system-testsjob. Before merging this PR, mentioned change should occur first.Local Testing
✅ Unit tests
✅ System tests