Skip to content

Proposal to reduce size of CRD #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 30, 2020
Merged

Proposal to reduce size of CRD #365

merged 4 commits into from
Sep 30, 2020

Conversation

coro
Copy link
Contributor

@coro coro commented Sep 28, 2020

No description provided.

@coro coro added the WIP This issue hasn't been discussed or scheduled. Do not work on it. label Sep 28, 2020
@mkuratczyk
Copy link
Collaborator

Is it possible to strip the descriptions of the embedded fields only (basically anything under spec.override)?

@coro
Copy link
Contributor Author

coro commented Sep 29, 2020

Is it possible to strip the descriptions of the embedded fields only (basically anything under spec.override)?

Unfortunately not. I saw a suggestion in the k/k issue that allowed kubebuilder to recursively skip description generation for fields with a // +kubebuilder: tag, but nothing like it is implemented yet.

@coro coro added design-doc-needed Design doc required before implementation and removed WIP This issue hasn't been discussed or scheduled. Do not work on it. labels Sep 29, 2020
@coro coro changed the title WIP: Proposal to reduce size of CRD Proposal to reduce size of CRD Sep 29, 2020
@coro coro marked this pull request as ready for review September 29, 2020 11:09
ChunyiLyu
ChunyiLyu approved these changes Sep 29, 2020
View reviewed changes
Copy link
Contributor

@ChunyiLyu ChunyiLyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 😸

@mkuratczyk
Copy link
Collaborator

It's actually 0, not -1, that make controller-gen drop CRD descriptions.

@coro
Copy link
Contributor Author

coro commented Sep 29, 2020

It's actually 0, not -1, that make controller-gen drop CRD descriptions.

Ah, they changed it due to review feedback, fair enough. - kubernetes-sigs/controller-tools#299 (comment)

@mkuratczyk mkuratczyk self-requested a review September 30, 2020 10:51
@coro coro merged commit 175ac9b into main Sep 30, 2020
@coro coro deleted the wip-sizing-proposal branch September 30, 2020 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChunyiLyu ChunyiLyu ChunyiLyu approved these changes

@mkuratczyk mkuratczyk mkuratczyk approved these changes

Assignees
No one assigned
Labels
design-doc-needed Design doc required before implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coro @mkuratczyk @ChunyiLyu