Remove expectation on token timeout #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zerpet
force-pushed
the
system-tests-mqtt
branch
from
3ef3a7d to
4863a88
Compare
coro
approved these changes
Oct 8, 2020
ansd
requested changes
Oct 8, 2020
The retry logic should contain no expectations because it's expected to fail sometimes and retry in such cases.
Zerpet
force-pushed
the
system-tests-mqtt
branch
from
4863a88 to
48d2f01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Summary Of Changes
Remove the expectations around token wait with timeout. This wait is inside the "retry loop", therefore
this function is expected to return false in some cases, which is fine because the loop will retry
shortly after. The expectation around the token error right after the retry loop is correct because
we don't know from the loop if the connection has been successful, therefore we have to assert on the
token success right after the retry loop to guarantee that the connection was a success (or fail the test otherwise).
Local Testing
System tests have changed one line. They should be green.