Use a tcp readiness probe instead of cli command #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rabbitmq-diagnostics check_port_connectivity as readiness probe causes context deadline exceeded errors, and pods could be stuck at terminating for deletion - reduce PeriodSeconds in readinessProbe to 10 seconds since a tcp probe should be less expansive than running a diagnostics command
MirahImage
approved these changes
Oct 26, 2020
mkuratczyk
approved these changes
Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #409
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Summary Of Changes
could be stuck at terminating for deletion
Additional Context
See issue: #409 for more details
Local Testing
Have run unit, integration, and system tests