Reuse cluster generator in configmap tests #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MirahImage
requested changes
Nov 20, 2020
ablease
force-pushed
the
reuse-cluster-generator-in-tests
branch
from
5dad54e to
f59008e
Compare
MirahImage
approved these changes
Nov 20, 2020
Zerpet
approved these changes
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #464
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Summary Of Changes
As suggested by @Zerpet in #464 this commit reuses the cluster generator, to clean up the config map tests.
Additional Context
Local Testing