Add missing chart properties #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a test to check if there are CRD properties not exposed by the chart
MirahImage
approved these changes
Nov 25, 2020
ChunyiLyu
pushed a commit
that referenced
this pull request
Nov 30, 2020
Add a test to check if there are CRD properties not exposed by the chart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add all CRD properties that we forgot to expose through the helm chart. There is also a test to find such properties in the future. We should run that test in unit-tests/CI but I'd like to discuss whether we can find a better way to execute the test, specifically not to rely on the
kubectl explugin so that:I think test automation can be a separate PR. For now the most important part is exposing the missing properties.