Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prometheus tls example #539

Merged
merged 3 commits into from
Jan 6, 2021
Merged

Add prometheus tls example #539

merged 3 commits into from
Jan 6, 2021

Conversation

Gsantomaggio
Copy link
Member

Summary Of Changes

With this PR #533 it is possible to enable the Prometheus tls endpoint.

Update the example to show how to use them

@mkuratczyk mkuratczyk self-requested a review January 4, 2021 11:27
Copy link
Collaborator

@mkuratczyk mkuratczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TLS values file seems to be incorrect:

helm upgrade --install prometheus prometheus-community/kube-prometheus-stack --values=kube-prometheus-stack-values-tls.yaml.example
Error: failed to parse kube-prometheus-stack-values-tls.yaml.example: error converting YAML to JSON: yaml: line 4: did not find expected key

@Gsantomaggio
Copy link
Member Author

@mkuratczyk fixed!

@mkuratczyk mkuratczyk self-requested a review January 5, 2021 13:59
Copy link
Collaborator

@mkuratczyk mkuratczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gsantomaggio Gsantomaggio merged commit a057a26 into main Jan 6, 2021
@Gsantomaggio Gsantomaggio deleted the add_prom_tls branch January 6, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants