Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prometheus fix standard port in TLS deploy #541

Merged
merged 3 commits into from
Jan 5, 2021
Merged

Prometheus fix standard port in TLS deploy #541

merged 3 commits into from
Jan 5, 2021

Conversation

Gsantomaggio
Copy link
Member

@Gsantomaggio Gsantomaggio commented Jan 4, 2021 •
edited
Loading

Enable the Prometheus standard port with the TLS deploy

I introduced this problem with this PR #533 found by @mkuratczyk

To recap the behaviour:

  • standard deploy:
    normal

  • tls deploy disableNonTLSListeners=false
    all

  • tls deploy disableNonTLSListeners = true
    disable

@Gsantomaggio Gsantomaggio changed the title Prom fix standard port Prometheus fix standard port in TLS deploy Jan 4, 2021
ansd
ansd approved these changes Jan 4, 2021
View reviewed changes
Copy link
Member

@ansd ansd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just reviewed #533.
This fixes issue 1 described in #533 (review).
Thanks!

@Gsantomaggio Gsantomaggio mentioned this pull request Jan 4, 2021
Merged
@mkuratczyk mkuratczyk marked this pull request as draft January 5, 2021 09:24
@Gsantomaggio Gsantomaggio marked this pull request as ready for review January 5, 2021 09:53
mkuratczyk
mkuratczyk approved these changes Jan 5, 2021
View reviewed changes
Copy link
Collaborator

@mkuratczyk mkuratczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gsantomaggio Gsantomaggio merged commit 39e1851 into main Jan 5, 2021
@MirahImage MirahImage deleted the prom_fix_standard_port branch July 14, 2021 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkuratczyk mkuratczyk mkuratczyk approved these changes

@ansd ansd ansd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gsantomaggio @mkuratczyk @ansd