Skip to content
This repository was archived by the owner on Nov 17, 2020. It is now read-only.

Use recon library to get process memory stats on Windows #224

Closed
lukebakken opened this issue Oct 3, 2017 · 0 comments
Closed

Use recon library to get process memory stats on Windows #224

lukebakken opened this issue Oct 3, 2017 · 0 comments
Assignees
@michaelklishin @gerhard @lukebakken
Labels
bug effort-low enhancement
Milestone
3.6.13

Comments

@lukebakken
Copy link
Contributor

lukebakken commented Oct 3, 2017 •
edited
Loading

#151483108

rabbitmq/rabbitmq-server#1270 introduced using wmic.exe to get the amount of memory used by erl.exe on Windows. #222 reverted this change and restored behavior to using erlang:memory().

This mailing list post provides a method to get memory use from the Erlang VM's allocator statistics. After some searching, it appears that this method in the recon library achieves the same result.

You can see here some comparison in memory reporting using several different methods. Note that the first value is from recon and the last two are from the code provided in the rabbitmq-users post. Those values also closely track what Task Manager showed in its output.

On Linux, the /proc/PID/statm file will be used, and ps for other Unix platforms.
@lukebakken lukebakken mentioned this issue Oct 3, 2017
Merged
@lukebakken lukebakken changed the title Use recon library to get process memory stats on Windows Use recon library to get process memory stats on all platforms Oct 4, 2017
@michaelklishin michaelklishin mentioned this issue Oct 6, 2017
Closed
@lukebakken lukebakken reopened this Oct 6, 2017
This was referenced Oct 6, 2017
Merged
Merged
@lukebakken lukebakken added this to the 3.6.13 milestone Oct 8, 2017
@lukebakken lukebakken changed the title Use recon library to get process memory stats on all platforms Use recon library to get process memory stats on Windows Oct 10, 2017
michaelklishin added a commit to rabbitmq/rabbitmq-server that referenced this issue Oct 11, 2017
@michaelklishin
Update default allocator strategy to match rabbitmq/rabbitmq-common#224
b7840cf
@michaelklishin michaelklishin mentioned this issue Oct 11, 2017
Merged
michaelklishin added a commit to rabbitmq/rabbitmq-server that referenced this issue Oct 12, 2017
@michaelklishin
Merge pull request #1389 from rabbitmq/rabbitmq-common-224
7a37407 
Update default node memory calculation strategy to match rabbitmq/rabbitmq-common#224
lukebakken added a commit that referenced this issue Oct 12, 2017
@lukebakken
Fix issues uncovered after merging #224
022d538 
Follow-up to #224

* R16 compatibility
* Trap noproc in an additional case
@lukebakken lukebakken mentioned this issue Oct 12, 2017
Merged
lukebakken added a commit to rabbitmq/rabbitmq-server that referenced this issue Oct 12, 2017
@lukebakken
Add additional vm_memory_calculation_strategy values to cuttlefish conf
b41ca16 
Requires rabbitmq/rabbitmq-common#224
lukebakken added a commit to rabbitmq/rabbitmq-server that referenced this issue Oct 12, 2017
@lukebakken
Add additional vm_memory_calculation_strategy values to cuttlefish conf
f678d1b 
Requires rabbitmq/rabbitmq-common#224
michaelklishin added a commit that referenced this issue Oct 12, 2017
@michaelklishin
Merge pull request #229 from rabbitmq/rabbitmq-common-224-compat-fixes
fbca905 
Fix issues uncovered after merging #224
michaelklishin added a commit to rabbitmq/rabbitmq-server that referenced this issue Oct 12, 2017
@michaelklishin
Update default allocator strategy to match rabbitmq/rabbitmq-common#224
e32c7d3
michaelklishin added a commit to rabbitmq/rabbitmq-server that referenced this issue Oct 12, 2017
@michaelklishin
Update default allocator strategy to match rabbitmq/rabbitmq-common#224
2fee330
michaelklishin added a commit to rabbitmq/rabbitmq-server that referenced this issue Oct 12, 2017
@michaelklishin
Merge pull request #1394 from rabbitmq/rabbitmq-common-224-master-lrb
c779305 
Update cuttlefish schema for rabbitmq/rabbitmq-common#224 changes
lukebakken added a commit to rabbitmq/rabbitmq-website that referenced this issue Oct 12, 2017
@lukebakken
Configuration changes for rabbitmq/rabbitmq-common#224
dff25a5 
See rabbitmq/rabbitmq-common#224
@lukebakken lukebakken mentioned this issue Oct 12, 2017
Merged
michaelklishin added a commit to rabbitmq/rabbitmq-website that referenced this issue Oct 12, 2017
@michaelklishin
Merge pull request #447 from rabbitmq/rabbitmq-common-224
2d1c666 
Configuration changes for rabbitmq/rabbitmq-common#224
@venkatrv venkatrv mentioned this issue Nov 22, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@michaelklishin michaelklishin

@gerhard gerhard

@lukebakken lukebakken

Labels
bug effort-low enhancement
Projects
None yet
Milestone
3.6.13
Development

No branches or pull requests
3 participants
@michaelklishin @gerhard @lukebakken