Backport hostname verification to 4.x.x #399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hostname verification isn't performed by default in the TLS handshake, this commit makes it easier to enable server hostname verification for both blocking and non-blocking IO modes. References #394 (cherry picked from commit fcc3dbb) Conflicts: src/main/java/com/rabbitmq/client/ConnectionFactory.java src/test/java/com/rabbitmq/client/test/ChannelRpcTimeoutIntegrationTest.java
This is a solution for Java 6. For Java 7 and more, setting the server validation algorithm on the SSLParameters is more appropriate. This commit tries to make the activation of hostname verification as simpler as possible for the developer. The client detects it's running on Java 6 and sets up the hostname verifier from the Commons HttpClient project (it's still possible to provide a customer HostnameVerifier). The client uses the SSLParameters solution if possible. References #394
acogoluegnes
deleted the
rabbitmq-java-client-394-tls-hostname-verification-4.x.x
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a backport of #398 to 4.x.x. It also adds support for TLS hostname verification with
HostnameVerifier(for Java 6).