This repository was archived by the owner on Nov 16, 2020. It is now read-only.
Only preserve stats for local queues #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukebakken
changed the title
lukebakken
changed the title
dcorbacho
suggested changes
Jul 3, 2017
src/rabbit_mgmt_gc.erl
Outdated
| handle_info({run_gc_soon, Interval}, State) -> | ||
| {noreply, start_timer(Interval, State)}; | ||
| handle_info(run_gc_soon, State) -> | ||
| {noreply, start_timer(5000, State)}; |
There was a problem hiding this comment.
Use an interval from config, so the default could be easily changed.
Else we'd have to wait for a full stats background gc which can take a very long time during which metrics may be duplicated in the UI. [#147753285]
kjnilsson
force-pushed
the
rabbitmq-management-427
branch
from
de8cc0a to
983a228
Compare
When zeroing out stats after deletion. [#147753285]
|
@kjnilsson - there used to be a change to this line to use |
|
@lukebakken that is correct. Management GC needs to use the cluster-wide list of queues in order to retain historical queue metrics for queues that used to reside on the current node. |
lukebakken
commented
Jul 6, 2017
| [insert_entry(queue_msg_stats, Queue, TS, | ||
| QNegStats, Size, Interval, false) | ||
| || {Size, Interval} <- BPolicies], | ||
| % these need to be delayed by an interval |
There was a problem hiding this comment.
@kjnilsson - is this comment still relevant? i.e, should a delay be introduced?
There was a problem hiding this comment.
Good point that can be removed.
…q-management-agent into rabbitmq-management-427
dcorbacho
approved these changes
Jul 10, 2017
michaelklishin
approved these changes
Jul 10, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rabbitmq/rabbitmq-management#427
Depends on rabbitmq/rabbitmq-server#1278