Quorum queue local delivery

[kjnilsson]

This allows consumer deliveries to be sent from followers that are local to the consuming channels (when available). When there isn't a local follower the leader will deliver the message as before.

This saves unnecessary network hops.

Needs latest Ra master.

[michaelklishin]

Do any test suite assertions need updating?

rabbit_fifo_SUITE > tests > return_checked_out_test
    #1. {error,
            {{badmatch,
                 {{rabbit_fifo,
                      {cfg,test,
                          {resource,"/",queue,<<"test">>},
                          {0,64000},
                          undefined,undefined,undefined,undefined,competing,
                          undefined,undefined,undefined},
                      #{},undefined,2,
                      {0,{[],[]}},
                      1,
                      #{<0.178.0> => {enqueuer,2,[],up}},
                      {rabbit_fifo_index,#{1 => ''},1,1},
                      {0,{[],[]}},
                      #{{<<"cid">>,<0.178.0>} =>
                            {consumer,#{},
                                #{0 => {1,{1,{0,first}}}},
                                1,0,1,simple_prefetch,auto,up}},
                      {[],[]},
                      {[],[]},
                      0,0,[],0,0},
                  [{monitor,process,<0.178.0>},
                   {send_msg,<0.178.0>,
                       {delivery,<<"cid">>,[{0,{0,first}}]},
                       [local,ra_event]},
                   {aux,active}]}},
             [{rabbit_fifo_SUITE,return_checked_out_test,1,
                  [{file,"test/rabbit_fifo_SUITE.erl"},{line,310}]},
              {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1754}]},
              {test_server,run_test_case_eval1,6,
                  [{file,"test_server.erl"},{line,1263}]},
              {test_server,run_test_case_eval,9,
                  [{file,"test_server.erl"},{line,1195}]}]}}

rabbit_fifo_SUITE > tests > return_checked_out_limit_test
    #1. {error,
            {{badmatch,
                 {{rabbit_fifo,
                      {cfg,test,
                          {resource,"/",queue,<<"test">>},
                          {0,64000},
                          undefined,undefined,undefined,undefined,competing,1,
                          undefined,undefined},
                      #{},undefined,2,
                      {0,{[],[]}},
                      1,
                      #{<0.181.0> => {enqueuer,2,[],up}},
                      {rabbit_fifo_index,#{1 => ''},1,1},
                      {0,{[],[]}},
                      #{{<<"cid">>,<0.181.0>} =>
                            {consumer,#{},
                                #{0 => {1,{1,{0,first}}}},
                                1,0,1,simple_prefetch,auto,up}},
                      {[],[]},
                      {[],[]},
                      0,0,[],0,0},
                  [{monitor,process,<0.181.0>},
                   {send_msg,<0.181.0>,
                       {delivery,<<"cid">>,[{0,{0,first}}]},
                       [local,ra_event]},
                   {aux,active}]}},
             [{rabbit_fifo_SUITE,return_checked_out_limit_test,1,
                  [{file,"test/rabbit_fifo_SUITE.erl"},{line,327}]},
              {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1754}]},
              {test_server,run_test_case_eval1,6,
                  [{file,"test_server.erl"},{line,1263}]},
              {test_server,run_test_case_eval,9,
                  [{file,"test_server.erl"},{line,1195}]}]}}

[lukebakken]

FWIW I see the same failures in rabbit_fifo_SUITE

[kjnilsson]

Ah yes I missed to run that suite. yes they will need updating as they assert of the effect which has now changed.

[michaelklishin]

Backported to v3.8.x.