Skip to content

Ignore casing of VALUES clause when inserting records using SQL #1052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 20, 2023
Merged

Ignore casing of VALUES clause when inserting records using SQL #1052

merged 3 commits into from
Apr 20, 2023

Conversation

aidanharan
Copy link
Contributor

@aidanharan aidanharan commented Apr 20, 2023 •
edited
Loading

When inserting records using exec_insert the casing of the VALUES clause is irrelevant. Updated the regex to be case-insensitive.

@aidanharan aidanharan changed the title Regex for VALUES clause should be case-insensitive Ignore casing of VALUES clause when inserting records using SQL Apr 20, 2023
@aidanharan aidanharan marked this pull request as ready for review April 20, 2023 14:55
@aidanharan aidanharan merged commit 98e57a6 into main Apr 20, 2023
@aidanharan aidanharan deleted the identity-insert-non-dbo-schema branch April 20, 2023 14:56
lavika pushed a commit to lavika/activerecord-sqlserver-adapter that referenced this pull request Sep 26, 2023
@aidanharan
Ignore casing of VALUES clause when inserting records using SQL (rail…
04ff462 
…s-sqlserver#1052)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
rails-7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aidanharan