Skip to content

Removed tests that no longer need to be coerced #1173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 0 additions & 26 deletions test/cases/coerced_tests.rb
Original file line number Diff line number Diff line change
Expand Up @@ -229,18 +229,6 @@ def test_update_date_time_attributes_with_default_timezone_local
end
end
end

# SQL Server does not have query for release_savepoint
coerce_tests! %r{an empty transaction does not raise if preventing writes}
test "an empty transaction does not raise if preventing writes coerced" do
ActiveRecord::Base.while_preventing_writes do
assert_queries_count(1, include_schema: true) do
Bird.transaction do
ActiveRecord::Base.lease_connection.materialize_transactions
end
end
end
end
end

class BelongsToAssociationsTest < ActiveRecord::TestCase
Expand Down Expand Up @@ -2368,20 +2356,6 @@ def test_preloads_belongs_to_a_composite_primary_key_model_through_id_attribute_
end
end

class BasePreventWritesTest < ActiveRecord::TestCase
# SQL Server does not have query for release_savepoint
coerce_tests! %r{an empty transaction does not raise if preventing writes}
test "an empty transaction does not raise if preventing writes coerced" do
ActiveRecord::Base.while_preventing_writes do
assert_queries_count(1, include_schema: true) do
Bird.transaction do
ActiveRecord::Base.lease_connection.materialize_transactions
end
end
end
end
end

class MigratorTest < ActiveRecord::TestCase
# Test fails on Windows AppVeyor CI for unknown reason.
coerce_tests! :test_migrator_db_has_no_schema_migrations_table if RbConfig::CONFIG["host_os"] =~ /mswin|mingw/
Expand Down
Loading