Skip to content

Updated error message in test to include sqlserver #1176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2024

Conversation

aidanharan
Copy link
Contributor

Coerce ActiveRecord::ConnectionAdapters::PoolConfig::ResolverTest#test_url_invalid_adapter test as sqlserver not included in error message.

https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/actions/runs/9094436581/job/24995515248

ActiveRecord::ConnectionAdapters::PoolConfig::ResolverTest#test_url_invalid_adapter [/usr/local/bundle/bundler/gems/rails-cb60cc0b1539/activerecord/test/cases/database_configurations/resolver_test.rb:19]:
Expected /Database\ configuration\ specifies\ nonexistent\ 'ridiculous'\ adapter\.\ Available\ adapters\ are:\ abstract,\ fake,\ mysql2,\ postgresql,\ sqlite3,\ trilogy\.\ Ensure\ that\ the\ adapter\ is\ spelled\ correctly\ in\ config\/database\.yml\ and\ that\ you've\ added\ the\ necessary\ adapter\ gem\ to\ your\ Gemfile\ if\ it's\ not\ in\ the\ list\ of\ available\ adapters\./ to match "Database configuration specifies nonexistent 'ridiculous' adapter. Available adapters are: abstract, fake, mysql2, postgresql, sqlite3, sqlserver, trilogy. Ensure that the adapter is spelled correctly in config/database.yml and that you've added the necessary adapter gem to your Gemfile if it's not in the list of available adapters.".

@aidanharan aidanharan marked this pull request as ready for review May 16, 2024 15:38
@aidanharan aidanharan merged commit 636c38f into main May 16, 2024
2 of 8 checks passed
@aidanharan aidanharan deleted the coerce-test_url_invalid_adapter branch May 16, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant