Skip to content

Use default inspect for database adapter #1196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2024
Merged

Conversation

aidanharan
Copy link
Contributor

Fix ActiveRecord::AdapterTest#test_0002_inspect does not show secrets:

https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/actions/runs/9627344416/job/26554338325#step:4:274

1) Failure:
ActiveRecord::AdapterTest#test_0002_inspect does not show secrets [/usr/local/bundle/bundler/gems/rails-0b89a3393599/activerecord/test/cases/adapter_test.rb:330]:
Expected /ActiveRecord::ConnectionAdapters::\w+:0x[\da-f]+ env_name="\w+" role=:writing>/ to match "#<ActiveRecord::ConnectionAdapters::SQLServerAdapter version: 7.2.0.beta2, azure: false>".

See rails/rails#50405

@aidanharan aidanharan marked this pull request as ready for review June 23, 2024 10:13
@aidanharan aidanharan merged commit b6fdbeb into main Jun 23, 2024
5 checks passed
@aidanharan aidanharan deleted the default-connection-inspect branch June 23, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant