Default to request's cookies_same_site_protection option #222
+48
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenharman
force-pushed
the
fix_same_site_option
branch
from
d7d4a49 to
e2c86c2
Compare
This brings the ActiveRecordStore in line with the CookieStore that ships with Rails. (see: rails/rails#45501) `ActionDispatch::Session::ActiveRecordStore` passes along whatever options it was configure with, and by default that DOES NOT include a `:same_site` value. So when `Rack::Session::SessionId` is created, it's defaulting `:same_site` to `nil` because the option is missing. That means, by the time `ActionDispatch`'s cookie middleware runs, there is a `:same_site` key, so it won't set the default.
stevenharman
force-pushed
the
fix_same_site_option
branch
from
e2c86c2 to
d06f4ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the
ActiveRecordStorein line with theCookieStorethat ships with Rails. (see: rails/rails#45501)ActionDispatch::Session::ActiveRecordStorepasses along whatever options it was configure with, and by default that DOES NOT include a:same_sitevalue. So whenRack::Session::SessionIdis created, it's defaulting:same_sitetonilbecause the option is missing. That means, by the timeActionDispatch's cookie middleware runs, there is a:same_sitekey, so it won't set the default specified inconfig/application.rbviaconfig.action_dispatch.cookies_same_site_protection = :none, for example.Fixes #214