Update README to mention pin_all_from for local modules #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added info about `pin_all_from` and note about migrating from sprockets to propshaft
radiantshaw
reviewed
Jan 13, 2022
|
@Rotario I find this info very useful. Are you able to finish the pull request? |
Co-authored-by: Nipun Paradkar <[email protected]>
Co-authored-by: Nipun Paradkar <[email protected]>
|
I've added the suggested changes |
tgaff
reviewed
Mar 31, 2023
| ``` | ||
| Which imports the function from `app/javascript/src/example_function.js`. | ||
|
|
||
| Note: Sprockets used to serve assets (albeit without filename digests) it couldn't find from the `app/javascripts` folder with logical relative paths, meaning pinning local files wasn't needed. Propshaft doesn't have this fallback, so when you use Propshaft you have to pin your local modules. |
There was a problem hiding this comment.
I think you may need to do this for production anyways. In development Sprockets will serve those plain assets (without the digest), but in production you'll likely see 404 for the same requests.
This could maybe be simplified to a warning to make sure that one pins all files one needs from app/javascript.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst migrating from sprockets to propshaft, my relative imports stopped working due to the differences in asset fallbacks. Which I think Sprockets does and Propshaft doesn't.
The README doesn't yet mention pin_all_from which is really useful to know to get relative imports working from the import map.