update tests to support Loofah in HTML5 parsing mode #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 2, 2022
Note that Loofah provides an escape hatch which is to set the environment variable LOOFAH_HTML4_MODE to return to the previous behavior. CI tests both html4 and html5 modes
flavorjones
force-pushed
the
flavorjones-use-html5-stack
branch
from
b8e7852 to
98c2f3f
Compare
|
Closing this, will shortly open a new PR that allows HTML5 parsing to be opted into, and which will support a Rails config to make HTML5 the default in a future release of Rails. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flavorjones/loofah#239 proposes to change Loofah's behavior to use the libgumbo HTML5 parser (
Nokogiri::HTML5) instead of libxml2's HTML4 parser (Nokogiri::HTML4).This branch updates the rails-html-sanitizer test suite to support either mode, and illustrates some of the typical changes in sanitized output.
I don't think any of the sanitization changes should be considered "breaking", and that's partly the point of this exercise -- to build confidence that swapping out Loofah's parser is not an unreasonable thing to do. But I'd love to hear from other folks.