Use asset_path with error checking for all calls to path_to_asset
#143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
April 18, 2014 20:04
|
❤️ |
rafaelfranca
added a commit
that referenced
this pull request
Apr 22, 2014
Use `asset_path` with error checking for all calls to `path_to_asset`
rafaelfranca
added a commit
that referenced
this pull request
Apr 22, 2014
Use `asset_path` with error checking for all calls to `path_to_asset`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
asset_pathwith error checking is aliased topath_to_asset_with_errors. This requires having to overridejavascript_path,javascript_url,stylesheet_path,stylesheet_urlin order to check if assets accessed using those helpers need to be included in the precompile array (this was not done in #84, which meansasset_pathproduces error messages whilejavascript_path, etc. does not). By aliasing theasset_pathwith error checking topath_to_assetswhich those helpers already use, we force the helpers to go through the error checking.Most of the changes are additions to the tests.