Skip to content

Fix failing absolute asset path test #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2014

Conversation

namukang
Copy link
Contributor

looks like my PR's merge misplaced @matthewd's test from #142, resulting in a broken build.
this fixes it

@rafaelfranca

@matthewd
Copy link
Member

❤️

@rafaelfranca
Copy link
Member

Is the order of test relevant? If so we should fix that.

@namukang
Copy link
Contributor Author

Nope, the order of tests isn't relevant.

The test was originally in ManifestHelperTest which sets up a manifest so that assets would have digests.
The test was breaking b/c it was inadvertently moved to PrecompileHelperTest which doesn't set the manifest in the setup.

rafaelfranca added a commit that referenced this pull request Apr 22, 2014
Fix failing absolute asset path test
@rafaelfranca rafaelfranca merged commit 5b94853 into rails:master Apr 22, 2014
@rafaelfranca
Copy link
Member

Ah, right. Thanks

rafaelfranca added a commit that referenced this pull request Apr 22, 2014
Fix failing absolute asset path test
@namukang namukang deleted the fix-absolute-test branch April 23, 2014 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants