Update railtie to ignore no-extension files #327
Conversation
Updated the railtie to ignore files with no extensions, such as LICENSE, that cause sprockets to error out on assets compilation.
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Why do you have a file like LICENCE in the app/assets folder? |
|
If it is because you are putting a vendor project inside app/assets you should move to |
|
Bower-rails seems to have a nasty habit of doing that. That being said, it's a concern of both components as breaking on a file with no-extension feels like a bug that should be addressed regardless. |
|
@rafaelfranca we're not the filename-police... if our code is going to barf on an extensionless file, it seems the least we can do is ignore it |
|
@matthewd yeah, agree. Thank you for double checking. BTW, this behavior is soft deprecated already and you should migrate to use the manifest file. |
Update railtie to ignore no-extension files
In previous versions it was possible to set (instead of extend) the `precompile` array. This was broken, seemingly by accident, in rails@af64798 fixes rails#218 fixes rails#327 fixes rails#390
Updated the railtie to ignore files with no extensions, such as LICENSE, that cause sprockets to error out on assets compilation.