-
Notifications
You must be signed in to change notification settings - Fork 186
generator: sync erb template #357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello @flavorjones 👋 Any pointers on why the CI is failing? I ran the test suite locally, and they all passed. |
@kinsomicrote based on the errors occurring for the Rails 6.1 build, it looks like |
Thank you, @javierjulio Would it be better to leave it as it was? For example, using |
@kinsomicrote you're welcome. That could work. In general though for both methods I don't know what the maintainers here would prefer. For example, they could suggest a Rails version conditional to account for the difference instead. I just wanted to help identify the reason for the failure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kinsomicrote Thank you for submitting this! I'd prefer to use a calling convention that's compatible with Rails 6.1 (rather than introduce version checks).
@flavorjones tests are passing now. Let me know if it's good to go. |
Quick note for posterity: the Namespaced models (e.g. |
This updates the erb template to be in sync with the template in rails/rails
8310f63
to
a64b7a4
Compare
I've rebased and squashed |
@kinsomicrote Thanks so much for doing this work!!! I'm going to open a second PR with your changes using the Rails 7.0 API so we can have a separate conversation about dropping Rails 6.1 feature support. Edit: that PR is #359. |
This updates the ERB template to be in sync with the template in rails/rails
Fixes #341.