Rename bin/webpack[-dev-server] to bin/webpacker[-dev-server] #3252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed `/bin/webpack` to `/bin/webpacker` and `/bin/webpack-dev-server` to `bin/webpacker-dev-server` to avoid confusion with underlying webpack executables.
justin808
changed the title
|
CI passes. What else should be tested? Most changes are in the docs. |
|
|
||
| 18. Try running `RAILS_ENV=production bin/rails assets:precompile`. If all goes well, don't forget to clean the generated assets with `bin/rails assets:clobber`. | ||
|
|
||
| 19. Run `yarn add webpack-dev-server` if those are not already in your dev dependencies. Make sure you're using v4+. | ||
|
|
||
| 20. Try your app! | ||
|
|
||
| 21. Update any scripts that called `/bin/webpack` or `bin/webpack-dev-server` to `/bin/webpacker` or `bin/webpacker-dev-server` |
There was a problem hiding this comment.
I think this should be the 20th step, the last step should always be Try your app! 😀
There was a problem hiding this comment.
We've got some other PRs with changes here, so I'll clean up all at once!
frullah
reviewed
Jan 1, 2022
|
|
||
| 18. Try running `RAILS_ENV=production bin/rails assets:precompile`. If all goes well, don't forget to clean the generated assets with `bin/rails assets:clobber`. | ||
|
|
||
| 19. Run `yarn add webpack-dev-server` if those are not already in your dev dependencies. Make sure you're using v4+. | ||
|
|
||
| 20. Try your app! | ||
|
|
||
| 21. Update any scripts that called `/bin/webpack` or `bin/webpack-dev-server` to `/bin/webpacker` or `bin/webpacker-dev-server` |
There was a problem hiding this comment.
Suggested change
| 21. Update any scripts that called `/bin/webpack` or `bin/webpack-dev-server` to `/bin/webpacker` or `bin/webpacker-dev-server` | |
| 21. Update any scripts that called `bin/webpack` to `bin/webpacker` and `bin/webpack-dev-server` to `bin/webpacker-dev-server` |
i think it can reduce confusion
|
Nice! |
tricknotes
added a commit
to tricknotes/webpacker
that referenced
this pull request
Jan 25, 2022
These commands have been renamed in rails#3252.
justin808
pushed a commit
to shakacode/shakapacker
that referenced
this pull request
Jan 25, 2022
These commands have been renamed in rails/webpacker#3252.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed
/bin/webpackto/bin/webpackerand/bin/webpack-dev-serverto
bin/webpacker-dev-serverto avoid confusion with underlying webpackexecutables.
Addresses #3237.