Skip to content

conditional: Document the new expression filter and new Pi5 boot variables #4106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

conditional: Document the new expression filter and new Pi5 boot variables #4106

wants to merge 1 commit into from

Conversation

timg236
Copy link
Contributor

@timg236 timg236 commented May 15, 2025

No description provided.

@timg236 timg236 force-pushed the expression-filter branch from 273eb3c to 99a19bf Compare May 15, 2025 12:59
@timg236 timg236 force-pushed the expression-filter branch from 99a19bf to 70a3759 Compare May 15, 2025 13:16
@timg236 timg236 force-pushed the expression-filter branch from 70a3759 to 601d2ff Compare May 15, 2025 13:50
@timg236 timg236 force-pushed the expression-filter branch from 601d2ff to beecdb7 Compare May 15, 2025 15:17
@timg236 timg236 force-pushed the expression-filter branch from beecdb7 to 649ea93 Compare May 15, 2025 15:53
@timg236
Copy link
Contributor Author

timg236 commented May 16, 2025

@lurch - Any more comments?

@timg236 timg236 force-pushed the expression-filter branch from 649ea93 to e425017 Compare May 16, 2025 14:44
@lurch
Copy link
Contributor

lurch commented May 16, 2025

This is not the PR to tweak Raspberry Pi "family" terminology so resolving this comment

Haha, fair enough.

since the naming is consistent within the page.

Sorry to keep nit-picking, but if you wanted to be consistent with the terminology on the rest of https://www.raspberrypi.com/documentation/computers/config_txt.html you'd need to use "Flagship models since Raspberry Pi 5, Compute Modules since CM5, and Keyboard models since Pi 500".
However that's a bit of a mouthful though, which is why I'd be happy to approve this PR if you changed "Raspberry Pi 5 and newer flagship devices only." to "Raspberry Pi 5 and newer devices only." or "Raspberry Pi 5 only." (because otherwise people might think that this only applies to Pi5 and not CM5).

@timg236
Copy link
Contributor Author

timg236 commented May 16, 2025

I'm ignoring the "Pi 5 family" vs "Flagship" vs "Pi 5" changes because the documentation repo is already inconsistent and I'm not sorting out as part of this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lurch lurch lurch left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timg236 @lurch