Skip to content

License information missing for boot/ files #933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
agraf opened this issue Jan 26, 2018 · 6 comments
Closed

License information missing for boot/ files #933

agraf opened this issue Jan 26, 2018 · 6 comments

Comments

@agraf
Copy link

agraf commented Jan 26, 2018

The boot/ directory contains a few files that have their license described in /README.md, but most of the files are not covered by any license and there is no explicit "fallback" license for the overall project.

Please either provide a project fallback license or explicitly mention the licensing terms for all boot/ files (like overlays, dtbs, etc).

@pelwell
Copy link
Contributor

pelwell commented Feb 8, 2018

/modules, /debug, /extra (except dt-blob.dts), the dtbs, overlays and associated README are built from source files in the kernel tree, and are covered by the same licence as the kernel images. /extra/dt-blob.dts and documentation/ilcomponents are, like the start.elfs, covered by LICENCE.broadcom.

I think this should cover all files now, but let me know if there are still omissions.

README.md will be updated accordingly.

@pelwell
Copy link
Contributor

pelwell commented Feb 8, 2018

See PR #938.

pelwell added a commit that referenced this issue Feb 8, 2018
Add licensing information for remaining files and directories.

See: #933
@agraf
Copy link
Author

agraf commented Feb 8, 2018

I think with the updated text, all "fixup*.dat" files are still not covered, right?

"loader.bin" does not appear in the /boot directory for me. I assume that file used to exist and got removed?

As for all GPL licensed files (kernel, dtbs, overlays) you need to refer to the exact code that produced these binaries. I assume that means you'll have to note the sha1 hash of your own kernel tree every time you update them. Also, are you 100% sure the overlays are generated from your kernel tree? Can you point me to the exact location?

Thanks!

@afaerber
Copy link
Contributor

afaerber commented Feb 8, 2018

I think with the updated text, all "fixup*.dat" files are still not covered, right?

...as already pointed out in my merged #498 commit back in 2015. ;)

@pelwell
Copy link
Contributor

pelwell commented Feb 8, 2018

You're right about the wildcard, fixup*.dat and loader.bin - I'll fixup dat. @afaerber I don't know how your change got lost - don't take it personally. 8-)

I don't feel we have to refer to the exact code that produced the GPLd binaries - it is all in the Linux source tree (apart from the C compiler), and that should be enough. And yes I am 100% sure the overlays are in our kernel tree - see https://github.com/raspberrypi/linux/tree/rpi-4.9.y/arch/arm/boot/dts/overlays/ (the dtb sources are one level up).

pelwell added a commit that referenced this issue Feb 8, 2018
Further tweaks.

See: #933
@agraf
Copy link
Author

agraf commented Feb 8, 2018

Thanks!

@agraf agraf closed this as completed Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants