Add example for MPL3115A2 altimeter #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 14, 2021 14:33
|
Where are we on this, are we ready to pass it to @kilograham for a final review? @lurch opinions? |
JamesH65
reviewed
Sep 2, 2021
| hsum += data.altitude; | ||
| } | ||
| printf("%d sample average -> t: %.4f C, h: %.4f m\n", MPL3115A2_FIFO_SIZE, tsum / MPL3115A2_FIFO_SIZE, hsum / MPL3115A2_FIFO_SIZE); | ||
| has_new_data = false; |
There was a problem hiding this comment.
There's no mutex protection on the has_new_data variable and it is set in the interrupt routine and tested here. However, its likely OK in this simple case.
|
I had one comment about a variable accessed in interrupt and main thread domain, but @kilograham may be OK with it. Otherwise LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an example for the MPL3115A2 altimeter with absolute pressure + temp sensor. To add some variety to the sea of pressure/temp sensors, this example demonstrates some of the more advanced features of this board and its different modes.
Checklist