some logs are not json format #2535
Conversation
Signed-off-by: fscnick <[email protected]>
Signed-off-by: fscnick <[email protected]>
|
@kevin85421 PTAL |
fscnick
changed the title
There was a problem hiding this comment.
Could you add a screenshot? CC @MortalHappiness: Could you shepherd this PR? I’m currently at KubeCon.
Thanks for the feedback. Here it is. |
|
Update: I found that it's hard to add the logger information. Since all of our loggers already include logger information, it's fine if the logs from the library don't contain it. We can still easily debug our own app. Let's not bother implementing this. @fscnick From your screenshot, it seems that the logger information is lost. Can you try to also log the logger? I mean before the log is set to json format, we know that this log is from If it's technically infeasible, feel free to leave another comment. |
Signed-off-by: fscnick <[email protected]>
| @@ -153,8 +154,11 @@ func main() { | |||
| combineLoggerR := zapr.NewLogger(combineLogger) | |||
|
|
|||
| ctrl.SetLogger(combineLoggerR) | |||
| klog.SetLogger(combineLoggerR) | |||
There was a problem hiding this comment.
Could you add comments to explain why we need to set up klog?
Signed-off-by: fscnick <[email protected]>
Signed-off-by: fscnick <[email protected]>
Why are these changes needed?
Some logs from client-go are not in JSON format.
According to kubernetes/client-go#18 (comment),
Calling
klog.SetLogger()applies logs with JSON format from client-go.Related issue number
Closes #2512
Checks