Added COUNTER mode for saga injectors #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added 'COUNTER' constant for saga injectors mode property This allows developers to use single saga many times in different components pages or similar systems - Saga mounts only once, increments counter - Saga unmounts only when all of same sagas are ejected - Issues with takeLatest could appear
BenLorantfy
reviewed
May 3, 2021
src/sagaInjectors.js
Outdated
| @@ -33,6 +41,7 @@ export function injectSagaFactory(store, isValid) { | |||
| const newDescriptor = { | |||
| ...descriptor, | |||
| mode: descriptor.mode || DAEMON, | |||
| [COUNTER_PROP]: 0, | |||
There was a problem hiding this comment.
Why not just call this count ?
Suggested change
| [COUNTER_PROP]: 0, | |
| count: 0, |
There was a problem hiding this comment.
I agree, its updated as mentioned!
src/sagaInjectors.js
Outdated
|
|
||
| // Clean up in development when mode is COUNTER | ||
| if ( | ||
| process.env.NODE_ENV !== 'production' && |
There was a problem hiding this comment.
why do we need to check if not production?
There was a problem hiding this comment.
TBH i don't even remember, i will make example with issue and solution
to demonstrate what this actual does
I might figure out why i did that a long time ago
meanwhile i have removed it, because non of the tests fail
- updated tests to support removal of this branch of code/logic
Comment on lines
+206
to
+209
| - `COUNTER` **[String][26]** The saga will be mounted similar to 'RESTART_ON_REMOUNT', only difference is that | ||
| saga will be mounted only once on first inject, and ejected when all injectors are unmounted. | ||
| So this enables you to have multiple injectors with same saga and key, only one instance of saga will run | ||
| and enables you to have system that are more similar to widgets |
There was a problem hiding this comment.
Suggested change
| - `COUNTER` **[String][26]** The saga will be mounted similar to 'RESTART_ON_REMOUNT', only difference is that | |
| saga will be mounted only once on first inject, and ejected when all injectors are unmounted. | |
| So this enables you to have multiple injectors with same saga and key, only one instance of saga will run | |
| and enables you to have system that are more similar to widgets | |
| - `COUNTER` **[String][26]** Similar to 'RESTART_ON_REMOUNT' except the | |
| saga will be mounted only once on first inject and ejected when all injectors are unmounted. | |
| This enables you to have multiple injectors with the same saga and key and only one instance of the saga will run |
There was a problem hiding this comment.
Thank you for help, i have updated as u suggested
now its much better!
- updated dynamic counter to count property of descriptor - updated COUNTER mode description in comments and typescript types - Removed delete part in development mode - Added tests to cover removal of injected saga in dev env
|
I have created example where we demonstrate how counter works |
BenLorantfy
approved these changes
May 9, 2021
BenLorantfy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few things:
Example
injectSaga({ key: "books", saga: booksSaga, mode: COUNTER })I hope this helps somebody, cheers