Skip to content

fix: compensate offset when trigger is shift #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

bbb169
Copy link
Contributor

@bbb169 bbb169 commented Jul 6, 2023

https://github.com/react-component/trigger/compare/master...bbb169:trigger:fixShiftShake?expand=1
[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

fix ant-design/ant-design#43204

💡 Background and solution

compensate offset when trigget is shift

📝 Changelog

Language Changelog
🇺🇸 English compensate offset when trigger is shift
🇨🇳 Chinese 弥补trigger溢出时计算的误差

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 741a1de

🤖 Generated by Copilot at 741a1de

@bbb169
Copy link
Contributor Author

bbb169 commented Jul 7, 2023

why compensate offset
这是改动这块地方代码的逻辑

@afc163 afc163 requested a review from zombieJ July 7, 2023 05:43
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #410 (3e552cc) into master (60583ce) will not change coverage.
The diff coverage is 50.00%.

❗ Current head 3e552cc differs from pull request most recent head a8c1696. Consider uploading reports for the commit a8c1696 to get more accurate results

@@           Coverage Diff           @@
##           master     #410   +/-   ##
=======================================
  Coverage   96.44%   96.44%           
=======================================
  Files          13       13           
  Lines         760      760           
  Branches      227      218    -9     
=======================================
  Hits          733      733           
  Misses         27       27           
Impacted Files Coverage Δ
src/hooks/useAlign.ts 96.53% <50.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zombieJ
Copy link
Member

zombieJ commented Jul 24, 2023

试了一下可以解,但是这个逻辑其实不应该走进去。

@zombieJ zombieJ merged commit 688579d into react-component:master Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tree-select 弹出框打开时,输入框移出屏幕时,弹出框位置会变化一点点
2 participants