Skip to content

fix: add HTMLHtmlElement to judgement of getVisibleArea #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

bbb169
Copy link
Contributor

@bbb169 bbb169 commented Jul 24, 2023

https://github.com/react-component/trigger/compare/master...bbb169:trigger:fixShiftShake?expand=1
[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

fix ant-design/ant-design#43609

💡 Background and solution

compensate offset when trigget is shift

📝 Changelog

Language Changelog
🇺🇸 English add HTMLHtmlElement to judgement of getVisibleArea
🇨🇳 Chinese 把HTMLHtmlElement 加入 getVisibleArea 函数的省略判断中

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 741a1de

🤖 Generated by Copilot at 741a1de

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #413 (cdc9fa2) into master (e408af5) will increase coverage by 0.60%.
Report is 12 commits behind head on master.
The diff coverage is 97.67%.

❗ Current head cdc9fa2 differs from pull request most recent head 3b0b7d2. Consider uploading reports for the commit 3b0b7d2 to get more accurate results

@@            Coverage Diff             @@
##           master     #413      +/-   ##
==========================================
+ Coverage   96.45%   97.06%   +0.60%     
==========================================
  Files          13       13              
  Lines         762      784      +22     
  Branches      219      229      +10     
==========================================
+ Hits          735      761      +26     
+ Misses         27       23       -4     
Files Changed Coverage Δ
src/Popup/index.tsx 90.00% <ø> (ø)
src/hooks/useAlign.ts 97.67% <95.00%> (+1.13%) ⬆️
src/hooks/useWatch.ts 100.00% <100.00%> (ø)
src/index.tsx 95.28% <100.00%> (+0.78%) ⬆️
src/util.ts 98.63% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bbb169 bbb169 force-pushed the fixOverflowTopTrigger branch from 8cddc4f to 3b0b7d2 Compare August 16, 2023 04:23
@bbb169
Copy link
Contributor Author

bbb169 commented Aug 16, 2023

@yoyo837 已改

@zombieJ zombieJ merged commit de74c0d into react-component:master Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The overflow-x property affects the position of AutoComplete and Select components
3 participants