Skip to content

docs: Add documentation search #1100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2024
Merged

docs: Add documentation search #1100

merged 1 commit into from
Jun 20, 2024

Conversation

hichemfantar
Copy link
Contributor

@hichemfantar hichemfantar commented Jun 10, 2024 •
edited
Loading

Summary

This PR introduces local offline search.

image

Test Plan

search only works in production

  1. generate a new build
  2. serve the build

@hichemfantar hichemfantar changed the title chore: Add docusaurus-lunr-search plugin feat: Add docusaurus-lunr-search plugin Jun 10, 2024
@hichemfantar hichemfantar changed the title feat: Add docusaurus-lunr-search plugin feat: Add documentation search Jun 10, 2024
@hichemfantar
Copy link
Contributor Author

@krizzu @tido64 can we merge this please

@hichemfantar hichemfantar changed the title feat: Add documentation search docs: Add documentation search Jun 20, 2024
krizzu
krizzu approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@krizzu krizzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, thanks!

@krizzu krizzu enabled auto-merge (squash) June 20, 2024 11:55
@krizzu krizzu merged commit badb63c into react-native-async-storage:main Jun 20, 2024
9 checks passed
@hichemfantar hichemfantar deleted the search branch August 22, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krizzu krizzu krizzu approved these changes

@tido64 tido64 Awaiting requested review from tido64 tido64 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hichemfantar @krizzu