-
Notifications
You must be signed in to change notification settings - Fork 473
remove android gradle plugin #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove android gradle plugin #207
Conversation
@krizzu please review and merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dulmandakh Thank you for the contribution! This looks great, left a question and small comment for you.
@krizzu fixed, please merge |
Hi @dulmandakh - What kind of issues were you seeing when there is a mismatch of the the app project and a module? Can you please link me to an example? |
@dulmandakh Actually, I think we don't need to have gradle project in the root. When developing AsyncStorage, you'd normally do it by using Android App - which we have, in Can you checkout changes with |
@krizzu removed Gradle wrapper |
@krizzu @dulmandakh - Please check a slightly different approach here: #209 - It achieves the same result (avoiding unnecessary dependency downloads/conflicts in an app project), but keeps the buildscript dependency in place. With this it is still possible to open the |
Closing in favor of #209 |
Summary:
RN modules don't need to include Android Gradle Plugin because it's included in App project, and version its mismatch between app and module causes issues.
This PR removes Android Gradle Plugin from android or module project, and created a root project, creating build.gradle.kts file, so that we can develop with Android Studio. Also removed buildToolsVersion because it's no longer required by Android Gradle Plugin. Then changed minSdkVersion to be 16 to comply with RN.
Once this PR merged, developers need to open async-storage in Android Studio instead of android folder inside it.
Test Plan:
The module will work as usual and expected