feat: launch emulator during run-android #676

jayu · 2019-09-05T01:23:10Z

Summary:

This PR resolves #142
TLDR;
Duringreact-native run-android the first of user's emulators will be launched if there is no any running android device/emulator

emulator -list-advs to get a list of emulators
emulator @FIRST_ON_LIST to run the first available emulator

Test Plan:

Generate a project with React-native >60.0
install CLI from my fork
run react-native run-android without launched emulator -> emulator is launching
run react-native run-android with launched emulator -> nothing new happens
run react-native run-android with device connected -> nothing new happens
run react-native run-android without launched emulator, emulator has saved snapshot -> emulator is launching

thymikee

Amazing!

packages/platform-android/src/commands/runAndroid/tryLaunchEmulator.ts

packages/platform-android/src/commands/runAndroid/runOnAllDevices.ts

packages/platform-android/src/commands/runAndroid/tryLaunchEmulator.ts

Titozzz · 2019-09-08T13:20:58Z

Something that bothers me, there is no point in declaring a function as async just to await its return, you are just overwrapping stuff as it already returns a promise.

jayu · 2019-09-09T07:49:27Z

Thanks, @Titozzz :) It was redundant, fixes.

thymikee

Last batches of adjustments and I think we're good :)
I wonder if we're able to come up with Genymotion (or other custom emulators I don't know of) support as a followup.

packages/platform-android/src/commands/runAndroid/tryLaunchEmulator.ts

thymikee

Still need to test it, but code-wise LGTM 👍 great work @jaysbytes

thymikee · 2019-09-11T13:10:14Z

cc @satya164 would you like to give it a try? :)

Co-Authored-By: Michał Pierzchała <[email protected]>

thymikee · 2019-09-11T18:27:35Z

Just tested locally and fixed a bug I encountered. Also adjusted the wording around errors, warnings and infos a bit. Once CI is happy, this is good to go

jayu · 2019-09-11T19:02:29Z

@thymikee thanks for the help with shipping of this awesome feature 😀

a-c-sreedhar-reddy · 2019-09-12T07:43:40Z

Wouldn't it be better if available emulators are shown and asked to select one?

thymikee · 2019-09-12T08:14:10Z

@a-c-sreedhar-reddy not sure about that. Current behavior matches what we do for iOS. Maybe it's worth to revisit. Can you please create a proposal for that where we can discuss better UX?

jsjoeio · 2019-11-13T18:19:24Z

Has this feature been included in a recent release?

I didn't see it mentioned in any of the latest release notes

Shan7anu · 2019-12-05T18:46:51Z

@jsjoeio Yes. It's available in the latest release.

C:\Users\Shan7anu\Desktop\RNProjects\Sample>react-native run-android

info Running jetifier to migrate libraries to AndroidX. You can disable it using "--no-jetifier" flag.
Jetifier found 864 file(s) to forward-jetify. Using 4 workers...
info Starting JS server...
info Launching emulator...
info Successfully launched emulator.
info Installing the app...

jsjoeio · 2019-12-05T19:05:56Z

Woohoo! Thanks for confirming @Shan7anu!

shon3005 · 2023-01-14T03:42:47Z

hello @jayu thanks for adding this feature. unfortunately i seem to be unable to get this to work.

for context, android studio is not running at the time i run npx react-native run-android in terminal.
additional information is that i get this error when i run the above command:
Failed to launch emulator. Reason: The emulator (Pixel_6_API_31) quit before it finished opening. You can try starting the emulator manually from the terminal with: /Library/Android/sdk/emulator/emulator @Pixel_6_API_31.

expected behavior:

android studio boots up
emulator automatically launches

actual behavior:

Build fails with an error com.android.builder.testing.api.DeviceException: No connected devices!

alternatively, i opened up android studio. emulator has not launched yet. i run npx react-native run-android in terminal.
expected behavior:

emulator automatically launches

actual behavior:

Build fails with an error com.android.builder.testing.api.DeviceException: No connected devices!

workaround:
I resorted to manually running my emulator. only then was i able to run the command npx react-native run-android smoothly.

cetfu · 2023-01-17T07:29:03Z

hello @jayu thanks for adding this feature. unfortunately i seem to be unable to get this to work.

for context, android studio is not running at the time i run npx react-native run-android in terminal. additional information is that i get this error when i run the above command: Failed to launch emulator. Reason: The emulator (Pixel_6_API_31) quit before it finished opening. You can try starting the emulator manually from the terminal with: /Library/Android/sdk/emulator/emulator @Pixel_6_API_31.

expected behavior:
1. android studio boots up

2. emulator automatically launches
actual behavior:
1. Build fails with an error `com.android.builder.testing.api.DeviceException: No connected devices!`
alternatively, i opened up android studio. emulator has not launched yet. i run npx react-native run-android in terminal. expected behavior:
1. emulator automatically launches
actual behavior:
1. Build fails with an error `com.android.builder.testing.api.DeviceException: No connected devices!`
workaround: I resorted to manually running my emulator. only then was i able to run the command npx react-native run-android smoothly.

I'm using Linux Mint and getting a similar error

$ npx react-native run-android
info JS server already running.
info Launching emulator...
error Failed to launch emulator. Reason: The emulator (telefon) quit before it finished opening. You can try starting the emulator manually from the terminal with: /home/furkan/Android/Sdk/emulator/emulator @telefon.
warn Please launch an emulator manually or connect a device. Otherwise app may fail to launch.

$ emulator -list-avds
telefon

jayu requested review from Esemesek, grabbou and thymikee as code owners September 5, 2019 01:23

thymikee reviewed Sep 5, 2019

View reviewed changes

thymikee requested changes Sep 9, 2019

View reviewed changes

packages/platform-android/src/commands/runAndroid/tryLaunchEmulator.ts Outdated Show resolved Hide resolved

packages/platform-android/src/commands/runAndroid/tryLaunchEmulator.ts Show resolved Hide resolved

jayu force-pushed the jaysbytes/launch_emulator branch from bc7f1f2 to ba53509 Compare September 11, 2019 12:59

thymikee approved these changes Sep 11, 2019

View reviewed changes

jayu and others added 9 commits September 11, 2019 20:09

feat: launch android emulator in run-android

8914975

test: fix tests due to changes

0f0b69a

refactor: address CR comments & improvements

0b3e574

fix: refetch devices info after emualtor launch

06e0129

fix: remove redundant async/await

bb5d5d3

fix: run emulator from android home path

53a8907

Co-Authored-By: Michał Pierzchała <[email protected]>

refactor: use interval to check if emulator is booted

d759f1a

fix emulator path

7019639

adjust wording

20bdb48

thymikee force-pushed the jaysbytes/launch_emulator branch from d6ea811 to 20bdb48 Compare September 11, 2019 18:23

moar adjustments

aae4e6b

thymikee merged commit c9790eb into react-native-community:master Sep 11, 2019

jayu mentioned this pull request Mar 5, 2020

run-android with specified emulator name #1038

Closed

feat: launch emulator during run-android #676

feat: launch emulator during run-android #676

Uh oh!

Conversation

jayu commented Sep 5, 2019

Summary:

Test Plan:

Uh oh!

thymikee left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Titozzz commented Sep 8, 2019

Uh oh!

jayu commented Sep 9, 2019

Uh oh!

thymikee left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

thymikee left a comment

Choose a reason for hiding this comment

Uh oh!

thymikee commented Sep 11, 2019

Uh oh!

thymikee commented Sep 11, 2019

Uh oh!

jayu commented Sep 11, 2019

Uh oh!

a-c-sreedhar-reddy commented Sep 12, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thymikee commented Sep 12, 2019

Uh oh!

jsjoeio commented Nov 13, 2019

Uh oh!

Shan7anu commented Dec 5, 2019

Uh oh!

jsjoeio commented Dec 5, 2019

Uh oh!

shon3005 commented Jan 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cetfu commented Jan 17, 2023

Uh oh!

Uh oh!

a-c-sreedhar-reddy commented Sep 12, 2019 •

edited

Loading

shon3005 commented Jan 14, 2023 •

edited

Loading