Skip to content

fix: avoid crashing on web #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2022
Merged

fix: avoid crashing on web #625

merged 1 commit into from
Jun 27, 2022

Conversation

vonovak
Copy link
Member

@vonovak vonovak commented Jun 27, 2022

Summary

closes #610, closes #614, closes #623

Test Plan

tested locally with an expo app

What's required for testing (prerequisites)?

expo app, where you can install this branch via

yarn add https://github.com/react-native-datetimepicker/datetimepicker#fix/avoid-web-crash

then run yarn web to test

What are the steps to reproduce (after prerequisites)?

Compatibility

web

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)
  • I have added automated tests, either in JS or e2e tests, as applicable

@vonovak vonovak marked this pull request as ready for review June 27, 2022 21:04
@vonovak vonovak enabled auto-merge (squash) June 27, 2022 21:04
@vonovak vonovak disabled auto-merge June 27, 2022 21:09
@vonovak vonovak enabled auto-merge (squash) June 27, 2022 21:09
@vonovak vonovak merged commit 69589a0 into master Jun 27, 2022
@vonovak vonovak deleted the fix/avoid-web-crash branch June 27, 2022 21:14
vonovak pushed a commit that referenced this pull request Jun 27, 2022
## [6.1.4](v6.1.3...v6.1.4) (2022-06-27)

### Bug Fixes

* avoid crashing on web ([#625](#625)) ([69589a0](69589a0))
@vonovak
Copy link
Member Author

vonovak commented Jun 27, 2022

🎉 This issue has been resolved in version 6.1.4 🎉

If this package helps you, consider sponsoring us! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant