Skip to content

fix(android_imports): added missing '.android' #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

diegonava6
Copy link

@diegonava6 diegonava6 commented May 25, 2022

Summary

Test Plan

Working feature test

Check this video

Scope

Android ✅

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)
  • I have added automated tests, either in JS or e2e tests, as applicable

Copy link

@coltonleach coltonleach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried this in my project, works perfectly and fixes my problem.

a flow rule was causing a [cannot-resolve-module] error
added type any to picker.android due to unclear type
@kjkurtz
Copy link

kjkurtz commented Jun 27, 2022

@vonovak Any chance you can merge this and cut a new release? I think this will help out a bunch of us! Thanks!

@vonovak vonovak mentioned this pull request Jun 27, 2022
5 tasks
@vonovak
Copy link
Member

vonovak commented Jun 27, 2022

hello folks, thank you for your patience. I superseded this PR by #625 which uses a little cleaner solution.

It will be released soon 🙂

@vonovak vonovak closed this in #625 Jun 27, 2022
@vonovak
Copy link
Member

vonovak commented Jun 27, 2022

🎉 This issue has been resolved in version 6.1.4 🎉

If this package helps you, consider sponsoring us! 🚀

@kjkurtz
Copy link

kjkurtz commented Jul 13, 2022

Thanks so much @vonovak for the fix! Things are working well now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants