Skip to content

Update Example App to RN 0.62.2 #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 27, 2020
Merged

Update Example App to RN 0.62.2 #146

merged 7 commits into from
Apr 27, 2020

Conversation

luancurti
Copy link
Member

@luancurti luancurti commented Apr 9, 2020

Summary

Update Example App to RN 0.62.2

Closes #145

Test Plan

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS ✅❌
Android ✅❌

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I mentioned this change in CHANGELOG.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)

@luancurti luancurti changed the title Fix/ios module rn 62 Fix ios module export with name Apr 9, 2020
@luancurti luancurti self-assigned this Apr 9, 2020
@luancurti luancurti added the enhancement New feature or request label Apr 9, 2020
@luancurti
Copy link
Member Author

luancurti commented Apr 9, 2020

I need test the Example App in Android Emulator

@vonovak
Copy link
Member

vonovak commented Apr 11, 2020

@luancurti just FYI I believe RCT_EXPORT_MODULE()can be used without any name, just take a look here https://github.com/facebook/react-native/search?q=RCT_EXPORT_MODULE&unscoped_q=RCT_EXPORT_MODULE

unless there was a breaking change in 0.62

but upgrading the example app is a good thing for sure 👍

@vonovak
Copy link
Member

vonovak commented Apr 15, 2020

@luancurti hi, do you have any timeline one when you want to finish migrating the example to latest RN (=this PR)? I'm asking because I also started to work on that in #144 but didn't finish because detox did not support 0.62.

so just asking because I want to avoid doing duplicate work :) Thanks

@luancurti
Copy link
Member Author

@luancurti hi, do you have any timeline one when you want to finish migrating the example to latest RN (=this PR)? I'm asking because I also started to work on that in #144 but didn't finish because detox did not support 0.62.

so just asking because I want to avoid doing duplicate work :) Thanks

I'll finish it today

@luancurti luancurti requested a review from vonovak April 19, 2020 20:20
@luancurti luancurti changed the title Fix ios module export with name Update Example App to RN 0.62.2 Apr 19, 2020
@luancurti luancurti force-pushed the fix/ios-module-rn-62 branch from 8fe6f78 to b901905 Compare April 19, 2020 21:35
@luancurti luancurti marked this pull request as ready for review April 19, 2020 21:35
@luancurti
Copy link
Member Author

I've create an package.json inside Example App to make auto link works equal a real app that have datetimepicker with dependency

@luancurti
Copy link
Member Author

We can wait the detox support to rn 62? @vonovak

@vonovak
Copy link
Member

vonovak commented Apr 19, 2020

@luancurti thank you for the work!

I've create an package.json inside Example App

I'm sorry, but I'm afraid that is not something we want to do. Could you please avoid doing that? Why did you do the change?

also, the CI is failing (flow)

Detox can wait until we have 62 support. Thank you :)

@luancurti
Copy link
Member Author

@luancurti thank you for the work!

I've create an package.json inside Example App

I'm sorry, but I'm afraid that is not something we want to do. Could you please avoid doing that? Why did you do the change?

I'll make the rollback. I make this change because I see another repo doing this like react-native-share but I respect your opinion

also, the CI is failing (flow)

Detox can wait until we have 62 support. Thank you :)

Ok, thank you too

@luancurti luancurti force-pushed the fix/ios-module-rn-62 branch from b901905 to a0593af Compare April 20, 2020 01:13
Copy link
Member

@vonovak vonovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for this! I left some comments that would be nice to get clarified. Thansk!

@vonovak
Copy link
Member

vonovak commented Apr 27, 2020

oops, I pushed directly into this branch, I didn't mean that. But anyway, I pushed those changes I wanted to make public.
@luancurti just so you know, I was doing some experiments with latest RN CLI on this branch, and pushed them in here.

@luancurti
Copy link
Member Author

luancurti commented Apr 27, 2020

oops, I pushed directly into this branch, I didn't mean that. But anyway, I pushed those changes I wanted to make public.
@luancurti just so you know, I was doing some experiments with latest RN CLI on this branch, and pushed them in here.

Feel free to make the changes, thanks for the help!

@luancurti
Copy link
Member Author

@vonovak Awesome! 🎉 thanks again!

@luancurti luancurti merged commit c864ac4 into master Apr 27, 2020
@vonovak
Copy link
Member

vonovak commented Apr 27, 2020

thank you!

@vonovak vonovak deleted the fix/ios-module-rn-62 branch April 27, 2020 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compile Build failing for react-native 0.62 (IOS)
3 participants