-
-
Notifications
You must be signed in to change notification settings - Fork 422
Update Example App to RN 0.62.2 #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I need test the |
@luancurti just FYI I believe unless there was a breaking change in 0.62 but upgrading the example app is a good thing for sure 👍 |
@luancurti hi, do you have any timeline one when you want to finish migrating the example to latest RN (=this PR)? I'm asking because I also started to work on that in #144 but didn't finish because detox did not support 0.62. so just asking because I want to avoid doing duplicate work :) Thanks |
I'll finish it today |
8fe6f78
to
b901905
Compare
I've create an |
We can wait the |
@luancurti thank you for the work!
I'm sorry, but I'm afraid that is not something we want to do. Could you please avoid doing that? Why did you do the change? also, the CI is failing (flow) Detox can wait until we have 62 support. Thank you :) |
I'll make the rollback. I make this change because I see another repo doing this like react-native-share but I respect your opinion
Ok, thank you too |
b901905
to
a0593af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for this! I left some comments that would be nice to get clarified. Thansk!
oops, I pushed directly into this branch, I didn't mean that. But anyway, I pushed those changes I wanted to make public. |
Feel free to make the changes, thanks for the help! |
@vonovak Awesome! 🎉 thanks again! |
thank you! |
Summary
Update Example App to RN 0.62.2
Closes #145
Test Plan
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.md
CHANGELOG.md
example/App.js
)