Persistent Scrollbars (Android only) #39
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ayc1 said it looks good. Should we get a PR and get this done ? |
|
@kpsroka This looks good to me! IMO, this is a small and non-breaking change, so it probably can just be a pull request on the main repo rather than an RFC. If there's sufficient push-back about it there then we can turn it into an RFC. |
|
closing this issue - will wait for the PR on the main repo. If the PR takes time, ping me, and i can fast track the process |
|
FYI @axe-fb, a PR has been submitted: facebook/react-native#22300 |
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Nov 27, 2018
Summary: This PR is a follow-up from the closed [discussions-and-proposals PR](react-native-community/discussions-and-proposals#39), that explains in more detail the rationale for adding this feature. Pull Request resolved: #22300 Reviewed By: fkgozali Differential Revision: D13121748 Pulled By: mdvacca fbshipit-source-id: 899641be79bdb41fa6649df0772c602a5e09b3b9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose Android's
setScrollbarFadingEnabledvia a ScrollView prop.