-
Notifications
You must be signed in to change notification settings - Fork 203
Add the option to pass headers to useImageDimensions #225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b3920ad
to
cabe581
Compare
Hey @LinusU, sorry for the direct mention, but I'm trying to get some movement in this PR. I've fixed the CI issues for this PR and I'm wondering if you'd be able to take a look at it to see if it's good to merge/release. |
75e8253
to
7911dfa
Compare
Sorry for not looking at this earlier, happy to merge if you can rebase on latest master |
Since the start coordinate isn't available on android, the start coordinate can be either undefined or ScreenRect This @types change makes that nuance a bit more clear DefinitelyTyped/DefinitelyTyped@f6b2d01#diff-e94ad9b79ba4f07235bfefa12c2789cd2d6cb690d9120309555f33ae51295244
7911dfa
to
69a6078
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 👍
🚀 PR was released in |
Summary
When using headers (for example for authentication) together with
Image
, you could not useuseImageDimensions
because it only includedImage.getSize
to determine the size of a remote image. This PR adds support for passing a second optionalheaders
param touseImageDimensions
which will then useImage.getSizeWithHeaders
from React Native.Test Plan
What's required for testing (prerequisites)?
A remote resource which requires a header (e.g auth header)
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.md
Notes
I edited this PR via Github, let me know if it requires changes