Skip to content

prepare for RNC #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 15, 2020
Merged

prepare for RNC #56

merged 3 commits into from
Feb 15, 2020

Conversation

pvinis
Copy link
Member

@pvinis pvinis commented Feb 12, 2020

Summary

Renaming everything from react-native-hooks to @react-native-community/hooks.
This is in preparation for a new release under the RNC org.

Test Plan

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS ✅❌
Android ✅❌

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I mentioned this change in CHANGELOG.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)

@pvinis
Copy link
Member Author

pvinis commented Feb 12, 2020

I'll wait on this until @dabit3 gives me the OK. I want him to be fully aware of this.

@dabit3
Copy link
Member

dabit3 commented Feb 12, 2020

Looks great @pvinis I appreciate you taking the initiative here and doing the work to make this happen.

@pvinis
Copy link
Member Author

pvinis commented Feb 12, 2020

Since you are here, should we skip the release under the current name, and go for a release under RNC with all the latest changes?

@dabit3
Copy link
Member

dabit3 commented Feb 12, 2020

@pvinis I think that makes sense, but I will say do what you think is best based on your judgement.

@pvinis
Copy link
Member Author

pvinis commented Feb 12, 2020

I'll merge this, and prepare for a 2.0.0(?) release under RNC.

After that, we can use https://docs.npmjs.com/cli/deprecate to show a message to people that they should install @react-native-community/hooks instead. This can be done for the current package current version, from your account.

(thanks @lucasbento for the deprecation tip!)

Copy link
Member

@lucasbento lucasbento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 😄

@pvinis
Copy link
Member Author

pvinis commented Feb 12, 2020

Thanks both. This is ready. I'll keep it open until we finalize with @Titozzz on the release process, then I'll merge and do a release. Then I'll notify @dabit3 again for a deprecation.

Woop RNC 🙌

@pvinis pvinis self-assigned this Feb 12, 2020
@pvinis pvinis merged commit 15b0437 into master Feb 15, 2020
@pvinis pvinis deleted the rename-for-rnc branch February 15, 2020 23:11
@pvinis
Copy link
Member Author

pvinis commented Feb 21, 2020

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants