Skip to content

Deprecate legacy #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 11, 2019
Merged

Deprecate legacy #60

merged 2 commits into from
Sep 11, 2019

Conversation

emin93
Copy link
Member

@emin93 emin93 commented Sep 11, 2019

Summary

In this PR, I removed support for the legacy version of the template. New tags on master will now trigger a build and release a new version on npm.

@emin93 emin93 requested a review from radko93 September 11, 2019 09:32
@emin93 emin93 mentioned this pull request Sep 11, 2019
Closed
radko93
radko93 requested changes Sep 11, 2019
View reviewed changes
@radko93 radko93 self-requested a review September 11, 2019 10:12
radko93
radko93 approved these changes Sep 11, 2019
View reviewed changes
Copy link
Collaborator

@radko93 radko93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go for it.

@emin93 emin93 merged commit 901dabd into master Sep 11, 2019
@emin93 emin93 deleted the deprecate-legacy branch September 11, 2019 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radko93 radko93 radko93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emin93 @radko93