fix time picker sometimes resets to previous value #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vonovak
approved these changes
Jul 28, 2020
vonovak
changed the title
vonovak
changed the title
vonovak
changed the title
vonovak
approved these changes
Jul 28, 2020
vonovak
pushed a commit
that referenced
this pull request
Jul 28, 2020
## [2.6.1](v2.6.0...v2.6.1) (2020-07-28) ### Bug Fixes * time picker sometimes resets to previous value ([#234](#234)) ([fda536b](fda536b))
|
🎉 This PR is included in version 2.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
SConaway
pushed a commit
to SConaway/datetimepicker
that referenced
this pull request
Aug 7, 2020
…etimepicker#234) * DateTimePicker iOS fix * [CHANGELOG] DateTimePicker iOS fix * Update CHANGELOG.md Co-authored-by: Vojtech Novak <[email protected]>
SConaway
pushed a commit
to SConaway/datetimepicker
that referenced
this pull request
Aug 7, 2020
## [2.6.1](react-native-datetimepicker/datetimepicker@v2.6.0...v2.6.1) (2020-07-28) ### Bug Fixes * time picker sometimes resets to previous value ([react-native-datetimepicker#234](react-native-datetimepicker#234)) ([fda536b](react-native-datetimepicker@fda536b))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Keeps values sent to JS side from resetting the native picker component on iOS.
fixes #192
It's a simple diff check on the Class'
setDate:methodTest Plan
What's required for testing (prerequisites)?
See issue above
What are the steps to reproduce (after prerequisites)?
See issue above
Compatibility
Checklist
I added the documentation inREADME.mdCHANGELOG.mdI updated the typed files (TS and Flow)I added a sample use of the API in the example project (example/App.js)Let me know if any other info/changes are needed :)