Skip to content

Move all fragment work to UI thread #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2020
Merged

Move all fragment work to UI thread #356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 8 additions & 12 deletions android/src/main/java/com/reactcommunity/rndatetimepicker/RNDatePickerDialogModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,22 +127,18 @@ public void open(@Nullable final ReadableMap options, final Promise promise) {
}

final FragmentManager fragmentManager = activity.getSupportFragmentManager();
final RNDatePickerDialogFragment oldFragment = (RNDatePickerDialogFragment) fragmentManager.findFragmentByTag(FRAGMENT_TAG);

if (oldFragment != null && options != null) {
UiThreadUtil.runOnUiThread(new Runnable() {
@Override
public void run() {
oldFragment.update(createFragmentArguments(options));
}
});

return;
}

UiThreadUtil.runOnUiThread(new Runnable() {
@Override
public void run() {
RNDatePickerDialogFragment oldFragment =
(RNDatePickerDialogFragment) fragmentManager.findFragmentByTag(FRAGMENT_TAG);

if (oldFragment != null && options != null) {
oldFragment.update(createFragmentArguments(options));
return;
}

RNDatePickerDialogFragment fragment = new RNDatePickerDialogFragment();

if (options != null) {
Expand Down
20 changes: 8 additions & 12 deletions android/src/main/java/com/reactcommunity/rndatetimepicker/RNTimePickerDialogModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,22 +104,18 @@ public void open(@Nullable final ReadableMap options, final Promise promise) {
// We want to support both android.app.Activity and the pre-Honeycomb FragmentActivity
// (for apps that use it for legacy reasons). This unfortunately leads to some code duplication.
final FragmentManager fragmentManager = activity.getSupportFragmentManager();
final RNTimePickerDialogFragment oldFragment = (RNTimePickerDialogFragment) fragmentManager.findFragmentByTag(FRAGMENT_TAG);

if (oldFragment != null && options != null) {
UiThreadUtil.runOnUiThread(new Runnable() {
@Override
public void run() {
oldFragment.update(createFragmentArguments(options));
}
});

return;
}

UiThreadUtil.runOnUiThread(new Runnable() {
@Override
public void run() {
RNTimePickerDialogFragment oldFragment =
(RNTimePickerDialogFragment) fragmentManager.findFragmentByTag(FRAGMENT_TAG);

if (oldFragment != null && options != null) {
oldFragment.update(createFragmentArguments(options));
return;
}

RNTimePickerDialogFragment fragment = new RNTimePickerDialogFragment();

if (options != null) {
Expand Down